Skip to content

feat: package page right sidebar scroll#805

Merged
danielroe merged 4 commits intonpmx-dev:mainfrom
onebyte8bits:feature/package-rigntbar-scroll
Feb 4, 2026
Merged

feat: package page right sidebar scroll#805
danielroe merged 4 commits intonpmx-dev:mainfrom
onebyte8bits:feature/package-rigntbar-scroll

Conversation

@onebyte8bits
Copy link
Contributor

@onebyte8bits onebyte8bits commented Feb 3, 2026 •
edited by Flo0806
Loading

Fixes: #598

The sidebar section of the package details page is now scrollable.

@vercel
Copy link

vercel bot commented Feb 3, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 4, 2026 10:19am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 4, 2026 10:19am
npmx-lunaria Ignored Ignored Feb 4, 2026 10:19am

Request Review

@wojtekmaj wojtekmaj mentioned this pull request Feb 3, 2026
Closed
@wojtekmaj

This comment was marked as outdated.

Sign in to view
@wojtekmaj
Copy link
Contributor

wojtekmaj commented Feb 3, 2026

@onebyte8bits Please make sure to rebase the PR so that the latest changes to CI pipeline could be applied, making your PR mergable again. Thanks!

@onebyte8bits onebyte8bits force-pushed the feature/package-rigntbar-scroll branch from d1c809a to dab1d8e Compare February 3, 2026 10:37
alexdln
alexdln reviewed Feb 3, 2026
View reviewed changes
app/pages/package/[...package].vue Outdated

@media (min-width: 1280px) {
.sidebar-scroll {
max-height: calc(100dvh - 6rem);
Copy link
Member

@alexdln alexdln Feb 3, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image (In the screenshot on the right there is a small empty black zone under the sidebar panel)

imo It's better to make something like a global variable --header-height: 3.75rem, use it as the height of the header, and calculate the dimensions dynamically from it here.

Copy link
Contributor Author

@onebyte8bits onebyte8bits Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image here?

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 3, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

The package page component's sidebar was refactored to replace an overflow-hidden wrapper with a new .sidebar-scroll element that allows independent vertical scrolling. Template and stylesheet changes add responsive max-height constraints, custom scrollbar styling for desktop viewports, and behaviour to hide the scrollbar by default and reveal it on hover or focus. Layout and public interfaces remain unchanged.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description directly references the linked issue (#598) and accurately describes the change made: enabling independent scrolling on the sidebar.
Linked Issues check ✅ Passed The pull request implements independent sidebar scrolling by introducing a scrollable wrapper with vertical scroll capability, directly addressing issue #598's requirement for sidebar scrollability.
Out of Scope Changes check ✅ Passed All changes are scoped to the package details page sidebar scrolling functionality. No unrelated modifications are present outside the linked issue's requirements.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Important

Action Needed: IP Allowlist Update

If your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:

  • ✨ 136.113.208.247/32 (new)
  • 34.170.211.100/32
  • 35.222.179.152/32

Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist.

Comment @coderabbitai help to get the list of available commands and usage tips.

@onebyte8bits
Copy link
Contributor Author

onebyte8bits commented Feb 3, 2026

@onebyte8bits Please make sure to rebase the PR so that the latest changes to CI pipeline could be applied, making your PR mergable again. Thanks!

done

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@danielroe danielroe added this pull request to the merge queue Feb 4, 2026
Merged via the queue into npmx-dev:main with commit e86a550 Feb 4, 2026
16 checks passed
This was referenced Feb 5, 2026
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexdln alexdln alexdln left review comments

@danielroe danielroe danielroe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can't scroll the sidebar until the bottom of the sidebar matches bottom of page

4 participants

@onebyte8bits @wojtekmaj @danielroe @alexdln